Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promslog: Only log basename, not full path #705

Merged
merged 1 commit into from
Oct 11, 2024
Merged

promslog: Only log basename, not full path #705

merged 1 commit into from
Oct 11, 2024

Conversation

roidelapluie
Copy link
Member

No description provided.

gotjosh
gotjosh approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this warrants a test but thought I would suggest it.

@roidelapluie
promslog: Only log basename, not full path
fdc50c7 
Signed-off-by: Julien <roidelapluie@o11y.eu>
@roidelapluie
Copy link
Member Author

Not sure if this warrants a test but thought I would suggest it.

added

@roidelapluie roidelapluie merged commit a9d2e3f into prometheus:main Oct 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotjosh gotjosh gotjosh approved these changes

@SuperQ SuperQ Awaiting requested review from SuperQ

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roidelapluie @gotjosh